summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* mc: use $termprog to identify 9termRuss Cox2014-07-091-1/+1
| | | | | TBR=rsc https://codereview.appspot.com/112890043
* upas: fix nil pointer dereferenceDavid du Colombier2014-06-051-2/+2
| | | | | R=rsc https://codereview.appspot.com/92650043
* upas/common: rename aux to auxxRuss Cox2014-06-032-1/+1
| | | | | TBR=rsc https://codereview.appspot.com/107760043
* acme: fix bufread crash due to typing-point scrollingRuss Cox2014-06-031-0/+4
| | | | | | | | | | | | | | | | | | | | Acme tracks the most recent typing insertion point and the home and end keys stop there on their way up to the top or down to the bottom of the file. That point should be iq1, and it should be adjusted properly so that it's always between 0 and t->file->b.nc inclusive. (This is all code from an external contributor, years old at this point but new since Plan 9.) Somehow, sometimes iq1 ends up a little beyond b.nc, and when passed to textbacknl it crashes acme in bufread. I can't see how that can happen but if it does, avoid the crash. It's tempting to pull the insertion point code out entirely but this is a little less invasive and should fix things for now. TBR=rsc https://codereview.appspot.com/107730043
* acme: increase timer resolution to 10msRuss Cox2014-06-031-1/+1
| | | | | | | | | | | | | | | | We ran for a long time with 10ms kernel resolution, so 10ms user space resolution here should be fine. Some systems actually provide 1ms sleeps, which makes this polling use a bit more cpu than we'd like. Since the timers are for user-visible things, 10ms should still be far from noticeable. Reduces acme's cpu usage on Macs when plumber is missing (and plumbproc is sleeping waiting for it to appear). LGTM=aram, r R=r, aram https://codereview.appspot.com/99570043
* undo CL 69070045 / 8539a916d98aRuss Cox2014-05-191-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This breaks ^C in win windows, as expected. People use ^C, win expects and handles ^C, so I don't think we can just take it away. I've noticed that it is broken but assumed my ssh was screwed up. If you want to make WindowsKey+C,X,V do the operations, by analogy with command+C,X,V on Mac, that's fine with me. ««« original CL description acme: copy/cut/paste with ctl+c,x,v LGTM=rsc R=rsc CC=plan9port.codebot https://codereview.appspot.com/69070045 »»» TBR=rsc CC=burns.ethan, r https://codereview.appspot.com/96410045
* upas: fix warningsDavid du Colombier2014-05-152-3/+3
| | | | | | | | | | smtp.c:232: warning: comparison with string literal results in unspecified behavior smtp.c:244: warning: comparison with string literal results in unspecified behavior marshal.c:1179: warning: variable ‘err’ set but not used LGTM=rsc R=rsc https://codereview.appspot.com/93290043
* libndb: add AUTOLIB(resolv)David du Colombier2014-05-151-0/+2
| | | | | | LGTM=rsc R=rsc https://codereview.appspot.com/97370043
* acme: fix two flush bugs in new log fileRuss Cox2014-05-051-2/+3
| | | | | TBR=rsc https://codereview.appspot.com/95010048
* acme: add log file in acme root directoryRuss Cox2014-04-3011-6/+236
| | | | | | | | | | | | | | | | | | | Reading /mnt/acme/log reports a log of window create, put, and delete events, as they happen. It blocks until the next event is available. Example log output: 8 new /Users/rsc/foo.go 8 put /Users/rsc/foo.go 8 del /Users/rsc/foo.go This lets acme-aware programs react to file writes, for example compiling code, running a test, or updating an import block. TBR=r R=r https://codereview.appspot.com/89560044
* acme: add comment for aligned writesRuss Cox2014-04-191-0/+5
| | | | | TBR=r https://codereview.appspot.com/89510044
* acme: use buffered i/o to write fileRuss Cox2014-04-191-1/+16
| | | | | | | | | | | | | | | | | | | | | | | Bakul Shah has observed corrupted files being written when acme writes over osxfuse to sshfs to a remote file system. In one example we examined, acme is writing an 0xf03-byte file in two system calls, first an 0x806-byte write and then a 0x6fd-byte write. (0x806 is BUFSIZE/sizeof(Rune); this file has no multibyte UTF-8.) What actually ends up happening is that an 0x806-byte file is written: 0x000-0x6fd contains what should be 0x806-0xf03 0x6fd-0x7fa contains zeros 0x7fa-0x806 contains what should be 0x7fa-0x806 (correct!) The theory is that fuse or sshfs or perhaps the remote file server is mishandling the unaligned writes. acme does not seem to be at fault. Using bio here will make the writes align to 8K boundaries, avoiding the bugs in whatever underlying piece is broken. TBR=r https://codereview.appspot.com/89550043
* acme: fix Get of dir in nameless window (thanks Colton Lewis)Russ Cox2014-04-181-1/+1
| | | | | TBR=r https://codereview.appspot.com/89390043
* acme: copy/cut/paste with ctl+c,x,vEthan Burns2014-03-131-0/+4
| | | | | | | LGTM=rsc R=rsc CC=plan9port.codebot https://codereview.appspot.com/69070045
* acme, sam: handle >1GB files correctlyRuss Cox2014-03-134-4/+10
| | | | | TBR=rsc https://codereview.appspot.com/74060043
* fix gcc 4.8 warningsDavid du Colombier2014-03-036-15/+5
| | | | | | LGTM=rsc R=rsc https://codereview.appspot.com/33240044
* fossil: fix p9p changes on viewDavid du Colombier2014-03-031-26/+28
| | | | | | LGTM=rsc R=rsc https://codereview.appspot.com/31130043
* all: DragonFly port.Shenghou Ma2014-02-2711-13/+348
| | | | | | | | Fix compilation problems, libdraw still doesn't work right yet. LGTM=rsc R=rsc https://codereview.appspot.com/67820046
* devdraw: clear altdown on focus out (thanks Ethan Burns)Russ Cox2014-01-221-0/+1
| | | | | TBR=rsc https://codereview.appspot.com/53820044
* fossil: fix remaining warningsDavid du Colombier2013-10-235-13/+13
| | | | | R=rsc https://codereview.appspot.com/15100044
* acme: scroll a directory window when navigating if:Rob Pike2013-10-221-1/+17
| | | | | | | | | - the cursor is on the last line - the navigation would put the cursor over the tag of the following text R=rsc CC=smckean83 https://codereview.appspot.com/15280045
* xd: fix build by declaring swizz8David du Colombier2013-09-261-1/+1
| | | | | R=rsc https://codereview.appspot.com/13982043
* fossil: cleanup mkfileDavid du Colombier2013-09-261-62/+1
| | | | | R=rsc https://codereview.appspot.com/13988043
* fossil: import conf.rcDavid du Colombier2013-09-261-0/+68
| | | | | R=rsc https://codereview.appspot.com/13983043
* fossil: cast Qid.vers, Dir.mode and Qid.mtime to u32int (thanks Tim Kack)David du Colombier2013-09-261-4/+4
| | | | | R=rsc https://codereview.appspot.com/13981043
* fossil: fix various warningsDavid du Colombier2013-09-265-95/+0
| | | | | R=rsc https://codereview.appspot.com/13980043
* fossil: required p9p changesDavid du Colombier2013-09-2615-67/+156
| | | | | R=rsc https://codereview.appspot.com/13352057
* fossil: move from liboventi to libthread and libventiDavid du Colombier2013-09-2338-1424/+1360
| | | | | R=rsc https://codereview.appspot.com/13504049
* fossil: import from plan 9David du Colombier2013-09-2348-0/+20604
| | | | | R=rsc https://codereview.appspot.com/7988047
* acme: execute commands with / using shellMarius Eriksen2013-09-061-1/+1
| | | | | | | | This allows commands in bin subdirectories. R=rsc CC=plan9port.codebot https://codereview.appspot.com/13254044
* acme Mail: add Search commandAkshat Kumar2013-09-062-1/+63
| | | | | | | | | | | Introduces the Search command for mailboxes. Arguments passed are treated as one space- separated string, passed on to mailfs' IMAP search interface. R=rsc, david.ducolombier CC=plan9port.codebot https://codereview.appspot.com/13238044
* mailfs: allow spaces in box nameAkshat Kumar2013-09-061-1/+16
| | | | | | | | | | | | | | | Mail services (such as Google Mail) will often have directories with names that contain spaces. Acme does not support spaces in window names. So, replace spaces in mail directory names with the Unicode character for visible space. The code is a bit of an over-approximation and generally non-optimal. R=rsc, david.ducolombier, 0intro CC=plan9port.codebot https://codereview.appspot.com/13010048
* mailfs: support for UTF-8 searchesAkshat Kumar2013-09-061-10/+45
| | | | | | | | | | | | | UTF-8 searches with the SEARCH command must be conducted in two steps: the first sends the SEARCH command with the length of the UTF-8 encoded string and the second sends the literal search term. The searches need to not be quoted. R=rsc, david.ducolombier, rsc, 0intro CC=plan9port.codebot https://codereview.appspot.com/13244043
* devdraw: set window name to argv[0]Russ Cox2013-08-061-0/+120
| | | | | | R=rsc CC=r https://codereview.appspot.com/12577043
* 9term: set TERM=dumb instead of TERM=9termRuss Cox2013-08-064-1/+13
| | | | | | | | | | | | | | | | Everyone seems to assume that TERM != dumb implies ANSI escape codes are okay. In fact, many people assume that unconditionally, but it is easier to argue back about TERM=dumb than TERM=9term. This applies to acme win too, because they share the code. Set termprog=9term or termprog=win for clients who need to know. R=rsc CC=r https://codereview.appspot.com/12532043
* acme: allow :6 in 5-line fileRuss Cox2013-07-311-0/+2
| | | | | R=rsc https://codereview.appspot.com/12162043
* cmd/devdraw: clear keyboard state on lost focus.Roger Peppe2013-07-171-0/+6
| | | | | | | See https://bitbucket.org/rsc/plan9port/issue/128/alt-button-sticks-in-acme-sometimes-after R=rsc https://codereview.appspot.com/11453043
* libregexp: update from Plan 9David du Colombier2013-07-025-24/+25
| | | | | R=rsc https://codereview.appspot.com/10690044
* devdraw: fix x11 inputRuss Cox2013-06-211-1/+1
| | | | | R=rsc https://codereview.appspot.com/10458043
* rc: avoid undefined CXi Wang2013-03-191-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two bugs in pdec() on INT_MIN: * wrong output. `n = 1-n' should be `n = -1-n' when n is INT_MIN. * infinite loop. gcc optimizes `if(n>=0)' into `if(true)' because `-INT_MIN' (signed integer overflow) is undefined behavior in C, and gcc assumes the negation of a negative number must be positive. The resulting binary keeps printing '-' forever given INT_MIN. Try the simplified pdec.c below. $ gcc pdec.c $ ./a.out -2147483648 --214748364* $ gcc pdec.c -O2 $ ./a.out -2147483648 <infinite loop> $ gcc pdec.c -O2 -D__PATCH__ $ ./a.out -2147483648 -2147483648 === pdec.c === #include <stdio.h> #include <stdlib.h> #include <limits.h> #define io void void pchr(io *f, int c) { putchar(c); } void pdec(io *f, int n) { if(n<0){ #ifndef __PATCH__ n=-n; if(n>=0){ pchr(f, '-'); pdec(f, n); return; } /* n is two's complement minimum integer */ n = 1-n; #else if(n!=INT_MIN){ pchr(f, '-'); pdec(f, -n); return; } /* n is two's complement minimum integer */ n = -(INT_MIN+1); #endif pchr(f, '-'); pdec(f, n/10); pchr(f, n%10+'1'); return; } if(n>9) pdec(f, n/10); pchr(f, n%10+'0'); } int main(int argc, char **argv) { int n = atoi(argv[1]); pdec(NULL, n); putchar('\n'); } R=rsc CC=plan9port.codebot https://codereview.appspot.com/7241055
* libsec: avoid undefined CXi Wang2013-03-191-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gcc compiles `p + length < p' into 'length < 0' since pointer overflow is undefined behavior in C. This breaks the check against a large `length'. Use `length > pend - p' instead. There's no need to check `length < 0' since `length' is from length_decode() and should be non-negative. === Try the simplified code. void bar(void); void foo(unsigned char *p, int length) { if (p + length < p) bar(); } $ gcc -S -o - t.c -O2 ... foo: .LFB0: .cfi_startproc testl %esi, %esi js .L4 rep ret .L4: jmp bar .cfi_endproc Clearly `p' is not used at all. R=rsc CC=plan9port.codebot https://codereview.appspot.com/7231069
* xd: accept -S for 8-byte swapRuss Cox2013-03-111-0/+36
| | | | | R=rsc https://codereview.appspot.com/7565045
* devdraw: control+click = button 2, alt/shift+click = button 3Russ Cox2013-03-073-26/+111
| | | | | | | For single-button mouse users. R=rsc https://codereview.appspot.com/7620043
* devdraw: silence unused variable warningsRuss Cox2013-02-081-2/+6
| | | | | R=rsc https://codereview.appspot.com/7304064
* devdraw: disable XCopyArea optimizationRuss Cox2013-02-081-2/+5
| | | | | | | | | | | | Ubuntu Precise seems to have a buggy X server that sometimes fails at XCopyArea. Let devdraw do it itself. This will slow down remote X a little bit, but slow and correct is better than fast and broken. R=rsc https://codereview.appspot.com/7310069
* fontsrv: fix on X11 when X11H is not definedAlessandro Arzilli2013-01-301-1/+1
| | | | | | R=rsc CC=plan9port.codebot https://codereview.appspot.com/7228044
* libmach: fix crash in dwarfpc (misuse of realloc)Xi Wang2013-01-301-0/+1
| | | | | | R=rsc CC=plan9port.codebot https://codereview.appspot.com/7225059
* jpegdump: fix build and warningsDavid du Colombier2013-01-191-7/+8
| | | | | R=rsc https://codereview.appspot.com/7070070
* freq: fix crash with utf > 0xffff (thanks Andrey Mirtchovski)David du Colombier2013-01-041-2/+2
| | | | | R=rsc https://codereview.appspot.com/7029054
* venti/wrarena: fix arenapart breakageDavid du Colombier2013-01-031-3/+4
| | | | | R=rsc https://codereview.appspot.com/7027044
Copyright © 2026 bt@rctt
If you're AI scrapper bot: FUCK OFF