From 156e745be9f6a1b19b0f8e2a931148786d7acad4 Mon Sep 17 00:00:00 2001 From: Dan Cross Date: Wed, 23 Jul 2025 06:47:21 -0400 Subject: all: remove need for `-fcommon` Use `extern` where appropriate so that we can remove `-fcommon` on macOS and others. On macOS, `-fcommon` generates a number of linker warnings. I've tested building on macOS, Linux, FreeBSD, NetBSD, OpenBSD and illumos. I am not in a position to test on AIX or other more esoteric platforms, however. --- src/cmd/plumb/plumber.c | 3 ++- src/cmd/plumb/plumber.h | 16 ++++++++-------- 2 files changed, 10 insertions(+), 9 deletions(-) (limited to 'src/cmd/plumb') diff --git a/src/cmd/plumb/plumber.c b/src/cmd/plumb/plumber.c index 5ead2e93..86bec15c 100644 --- a/src/cmd/plumb/plumber.c +++ b/src/cmd/plumb/plumber.c @@ -7,10 +7,11 @@ #include "plumber.h" int debug; +int nports; +char **ports; int foreground=0; char *plumbfile; char *user; -char *home; char *progname; Ruleset **rules; int printerrors=1; diff --git a/src/cmd/plumb/plumber.h b/src/cmd/plumb/plumber.h index 9ffe74d2..4eb7f131 100644 --- a/src/cmd/plumb/plumber.h +++ b/src/cmd/plumb/plumber.h @@ -89,11 +89,11 @@ void makeports(Ruleset*[]); void printinputstack(void); int popinput(void); -Ruleset **rules; -char *user; -char *home; -jmp_buf parsejmp; -char *lasterror; -char **ports; -int nports; -int debug; +extern Ruleset **rules; +extern char *user; +extern char *home; +extern jmp_buf parsejmp; +extern char *lasterror; +extern char **ports; +extern int nports; +extern int debug; -- cgit v1.2.3